fix(golang): reject go_type specs with slash before type name#4426
Open
SAY-5 wants to merge 1 commit intosqlc-dev:mainfrom
Open
fix(golang): reject go_type specs with slash before type name#4426SAY-5 wants to merge 1 commit intosqlc-dev:mainfrom
SAY-5 wants to merge 1 commit intosqlc-dev:mainfrom
Conversation
Specs like "github.com/foo/pkg/Type" used to silently emit a broken "github" import; require the conventional dot separator. Fixes sqlc-dev#4192.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4192.
A
go_typespec likegithub.com/foo/pkg/Type(slash before the type name instead of the conventional dot) used to fall back to the last dot anywhere in the spec, which lands insidegithub.com. The generatedmodels.goended up withimport ("github"), which does not compile.This change rejects these specs in the parser with the same error already used for specs that contain no dot, pointing the user at the expected
'package.type'format. Adds a regression case inTestTypeOverrides.